fix(chore): save new event even with empty title - #8556

Thank for the PR @max65482

@odzhychko What do you think?

The fix is correct. But I am wondering if that is the correct behavior, should we allow someone to save an event with a empty title? I mean there is a minimum amount of in formation required to have a use full event displayed in the calendar. Would any one ever want a event with no title?

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

📢 Thoughts on this report? Let us know!

Thank for the PR @max65482

@odzhychko What do you think?

The fix is correct. But I am wondering if that is the correct behavior, should we allow someone to save an event with a empty title? I mean there is a minimum amount of in formation required to have a use full event displayed in the calendar. Would any one ever want a event with no title?

Hm, I still think it is (the more) correct behavior, because an event created like this still has a date and a time.
Hypothetically, It could be useful if one wants to create unnamed blockers 🤷

The next best behavior, I can think of, would be to disable the save button until something has changed.
Still a user could type in some title, then remove the title, save the event and have the same result.
That would be just inconsistent 😄

Hm, I still think it is (the more) correct behavior, because an event created like this still has a date and a time. Hypothetically, It could be useful if one wants to create unnamed blockers 🤷

Okay, if we let people create events with out a title we should force a generic time at creation time (In my option)

The next best behavior, I can think of, would be to disable the save button until something has changed. Still a user could type in some title, then remove the title, save the event and have the same result. That would be just inconsistent 😄

That might the best solution, the only problem is the mark dirty trigger (this.calendarObjectInstance.eventComponent.markDirty()) is not reactive, I believe. I believe all the components and properties in eventComponent are not reactive.Would need to double check

Okay, if we let people create events with out a title we should force a generic time at creation time (In my option)

I found no way to create an event without a date. A time is automatically set, when

• using the "+ Event" button
• clicking (or dragging) inside the calendar view

I'd go with the principle of least surprise. Thunderbird, Outlook (old) and Outlook (new) let you create events with empty title. Outlook (new) asks you whether you want to save an event with empty title.

I'd go with the principle of least surprise. Thunderbird, Outlook (old) and Outlook (new) let you create events with empty title. Outlook (new) asks you whether you want to save an event with empty title.

Sounds good. Thanks for checking and summarizing it.